SearchFilter: allow on dates

Author: soyuka

features/doctrine/search_filter.feature

@@ -1039,3 +1039,11 @@ Feature: Search filter on collections
       }
     }
     """
+
+  @createSchema
+  Scenario: Search by date (#4128)
+    Given there are 3 dummydate objects with dummyDate
+    When I send a "GET" request to "/dummy_dates?dummyDate=2015-04-01"
+    Then the response status code should be 200
+    And the response should be in JSON
+    And the JSON node "hydra:totalItems" should be equal to 1

src/Bridge/Doctrine/Orm/Filter/SearchFilter.php

@@ -162,6 +162,9 @@ protected function addWhereByStrategy(string $strategy, QueryBuilder $queryBuild
     {
         if (\func_num_args() > 7 && ($metadata = func_get_arg(7)) instanceof ClassMetadata) {
             $type = $metadata->getTypeOfField($field);
+            if ($type && \DateTimeInterface::class === $this->getType($type)) {
+                $type = null;
+            }
         } else {
             @trigger_error(sprintf('Method %s() will have a 8th argument `$metadata` in version API Platform 3.0.', __FUNCTION__), \E_USER_DEPRECATED);
             $type = null;

tests/Fixtures/TestBundle/Document/DummyDate.php

@@ -16,6 +16,7 @@
 use ApiPlatform\Core\Annotation\ApiFilter;
 use ApiPlatform\Core\Annotation\ApiResource;
 use ApiPlatform\Core\Bridge\Doctrine\MongoDbOdm\Filter\DateFilter;
+use ApiPlatform\Core\Bridge\Doctrine\MongoDbOdm\Filter\SearchFilter;
 use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
 
 /**
@@ -27,6 +28,7 @@
  * @ApiResource(attributes={
  *     "filters"={"my_dummy_date.mongodb.date"}
  * })
+ * @ApiFilter(SearchFilter::class, properties={"dummyDate"})
  * @ApiFilter(DateFilter::class, properties={
  *     "dateIncludeNullAfter"=DateFilter::INCLUDE_NULL_AFTER,
  *     "dateIncludeNullBefore"=DateFilter::INCLUDE_NULL_BEFORE,

tests/Fixtures/TestBundle/Entity/DummyDate.php

@@ -16,6 +16,7 @@
 use ApiPlatform\Core\Annotation\ApiFilter;
 use ApiPlatform\Core\Annotation\ApiResource;
 use ApiPlatform\Core\Bridge\Doctrine\Orm\Filter\DateFilter;
+use ApiPlatform\Core\Bridge\Doctrine\Orm\Filter\SearchFilter;
 use Doctrine\ORM\Mapping as ORM;
 
 /**
@@ -26,6 +27,7 @@
  * @ApiResource(attributes={
  *     "filters"={"my_dummy_date.date"}
  * })
+ * @ApiFilter(SearchFilter::class, properties={"dummyDate"})
  * @ApiFilter(DateFilter::class, properties={
  *     "dateIncludeNullAfter"=DateFilter::INCLUDE_NULL_AFTER,
  *     "dateIncludeNullBefore"=DateFilter::INCLUDE_NULL_BEFORE,