ci: remove deprecated packages from composer.json #3794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dunglas
force-pushed
the
fix/deprecations
branch
2 times, most recently
from
f3a9103 to
84190e4
Compare
stloyd
reviewed
Oct 27, 2020
src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
dunglas
force-pushed
the
fix/deprecations
branch
from
1c98d40 to
3c74d18
Compare
dunglas
commented
Oct 29, 2020
dunglas
commented
Oct 29, 2020
dunglas
force-pushed
the
fix/deprecations
branch
4 times, most recently
from
49bedaf to
e03df00
Compare
Co-authored-by: Joseph Bielawski <stloyd@users.noreply.github.com>
dunglas
force-pushed
the
fix/deprecations
branch
from
4ce5e11 to
6fd9b3c
Compare
dunglas
force-pushed
the
fix/deprecations
branch
from
3da0d6f to
2e4f33a
Compare
soyuka
reviewed
Nov 5, 2020
| try { | ||
| require_once $sourceFile; | ||
| } catch (\Throwable $t) { | ||
| // invalid PHP file (example: missing parent class) |
There was a problem hiding this comment.
should'nt we log at least so that the user knows there's an issue in this class?
There was a problem hiding this comment.
It's usually not an issue but an optional dependency not installed or something like that. If the class is used elsewhere, PHP will throw an error anyway.
soyuka
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NelmioApiDoc v2 and FOSUserBundle aren't maintained anymore. They prevent installing the latest version of some Symfony component. This PR removes theses packages from
composer.json(the integration with these legacy tools will not be tested in the CI either).