Add false positives to PHPStan #3805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alanpoulain
commented
Oct 30, 2020
alanpoulain
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tickets | N/A |
| License | MIT |
| Doc PR | N/A |
alanpoulain
force-pushed
the
fix/phpstan
branch
from
2091ca7 to
99bcbf3
Compare
dunglas
reviewed
Nov 2, 2020
| message: '#Cannot assign new offset to string\.#' | ||
| path: src/JsonSchema/SchemaFactory.php | ||
| - | ||
| message: '#Instanceof between bool\|float\|int\|null and ArrayObject will always evaluate to false\.#' |
There was a problem hiding this comment.
Can we add inline @phpstan-ignore-line comments in the file itself instead of using this file?
|
This will be fixed by #3794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.