Fix #3982 maxDepth property of the ApiSubresource annotation not working #3986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixing... |
crbanman
commented
Jan 26, 2021
crbanman
changed the title
soyuka
approved these changes
Jan 27, 2021
alanpoulain
reviewed
Jan 31, 2021
| */ | ||
| public function __construct($maxDepth = null) | ||
| { | ||
| if (!\is_array($maxDepth)) { // @phpstan-ignore-line |
There was a problem hiding this comment.
Shouldn't we modify the PHPDoc?
There was a problem hiding this comment.
Not really as we want to keep the auto documentation as we did in https://github.com/api-platform/core/blob/main/src/Annotation/ApiResource.php this happens only when using this class as a php 8 attribute
alanpoulain
approved these changes
Jan 31, 2021
added 7 commits
January 31, 2021 23:37
…ion not working
…ructure to appease phpstan
|
thanks @crbanman ! |
cacahouwete
pushed a commit
to cacahouwete/core
that referenced
this pull request
Feb 8, 2021
…ion not working (api-platform#3986) * fix api-platform#3982 maxDepth property of the ApiSubresource annotation not working * always pass array to hydrateAttributes() * add test for ApiSubresource and further align with other annotations with same trait * remove AttributesHydratorTrait * handle null case * remove array type from $maxDepth parameter and changed constructor structure to appease phpstan * have phpstan ignore a test line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxDepthparameter of theApiSubresourcenot working