-
-
Notifications
You must be signed in to change notification settings - Fork 933
Fix #3982 maxDepth property of the ApiSubresource annotation not working #3986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6ed7713
fix #3982 maxDepth property of the ApiSubresource annotation not working
f20ac33
always pass array to hydrateAttributes()
98ce7ca
add test for ApiSubresource and further align with other annotations …
93c3a9c
remove AttributesHydratorTrait
ef64267
handle null case
e44c308
remove array type from $maxDepth parameter and changed constructor st…
36d35f3
have phpstan ignore a test line
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the API Platform project. | ||
* | ||
* (c) Kévin Dunglas <dunglas@gmail.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace ApiPlatform\Core\Tests\Annotation; | ||
|
||
use ApiPlatform\Core\Annotation\ApiSubresource; | ||
use PHPUnit\Framework\TestCase; | ||
|
||
/** | ||
* @author Cody Banman <crbanman@gmail.com> | ||
*/ | ||
class ApiSubresourceTest extends TestCase | ||
{ | ||
public function testAssignation() | ||
{ | ||
$property = new ApiSubresource(); | ||
$property->maxDepth = 1; | ||
|
||
$this->assertEquals(1, $property->maxDepth); | ||
} | ||
|
||
public function testConstruct() | ||
{ | ||
$property = new ApiSubresource([ // @phpstan-ignore-line | ||
'maxDepth' => 1, | ||
]); | ||
$this->assertEquals(1, $property->maxDepth); | ||
} | ||
|
||
/** | ||
* @requires PHP 8.0 | ||
*/ | ||
public function testConstructAttribute() | ||
{ | ||
$property = eval(<<<'PHP' | ||
return new \ApiPlatform\Core\Annotation\ApiSubresource( | ||
maxDepth: 1 | ||
); | ||
PHP | ||
); | ||
$this->assertEquals(1, $property->maxDepth); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we modify the PHPDoc?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really as we want to keep the auto documentation as we did in https://github.com/api-platform/core/blob/main/src/Annotation/ApiResource.php this happens only when using this class as a php 8 attribute