fix: use different pagination types for the queries of a resource #4453
Conversation
webda2l
changed the title
|
I think it can be considered as a feature. |
https://api-platform.com/docs/core/graphql/#using-the-page-based-pagination could be interpreted as it's already implemented. Same about the second issue i mentioned, https://api-platform.com/docs/core/pagination/#changing-the-number-of-items-per-page-client-side-for-a-specific-resource (that can only be disabled by resource/query, but only if enabled globally, and not the inverse) |
CHANGELOG.md
Outdated
|
|
||
| ## 2.7.0 | ||
|
|
||
| * GraphQL: Add ability to use different pagination type from queries of a same resource (#4453) |
There was a problem hiding this comment.
| * GraphQL: Add ability to use different pagination type from queries of a same resource (#4453) | |
| * GraphQL: Add ability to use different pagination types for the queries of a resource (#4453) |
src/GraphQl/Type/TypeBuilder.php
Outdated
|
|
||
| $resourcePaginatedCollectionType = new ObjectType($configuration); | ||
| $this->typesContainer->set("{$shortName}Connection", $resourcePaginatedCollectionType); | ||
| $this->typesContainer->set("{$shortName}Connection_{$paginationType}", $resourcePaginatedCollectionType); |
There was a problem hiding this comment.
IMO, the type should be:
shortNameCursorConnection
Could you please make the changes to obtain this?
src/GraphQl/Type/TypeBuilder.php
Outdated
| 'name' => "{$shortName}Connection", | ||
| 'description' => "Connection for $shortName.", | ||
| 'name' => "{$shortName}Connection_{$paginationType}", | ||
| 'description' => "Connection for $shortName. ({$paginationType})", |
There was a problem hiding this comment.
IMO it should be:
Page connection for shortName
webda2l
changed the title
|
Thank you @webda2l. |
You're welcome! Thanks to you and CoopTilleuls for your work. :) |
2 participants
See if considered as fix or not?
Use case:
By the way, there is still an issue about
paginationClientEnabledthat is available in the QueryCollection attribute (or even ApiResource attribute), but inactive per query (or even resource) if not enabled at default configuration level byapi_platform.defaults.pagination_client_items_per_page: trueBut to resolve this another issue, it require more deeper changes.