Skip to content

Conversation

alOneh
Copy link
Contributor

@alOneh alOneh commented Oct 25, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tickets #144
License MIT
Doc PR api-platform/docs#987

@alOneh alOneh force-pushed the feature/vuetify-generator branch 3 times, most recently from 1b15a40 to eb5d65e Compare November 8, 2019 22:46
@alOneh alOneh changed the title feat(generator): vuetify Add Vuetify generator Nov 8, 2019
@alOneh alOneh force-pushed the feature/vuetify-generator branch 3 times, most recently from fd97a71 to 80763b6 Compare November 11, 2019 15:43
@alOneh
Copy link
Contributor Author

alOneh commented Nov 12, 2019

@pierrejoye can you test/review this Vuetify generator and make feedback on it, when you have any time ?

@alOneh alOneh force-pushed the feature/vuetify-generator branch 2 times, most recently from aa25ed5 to 703c745 Compare November 12, 2019 22:02
@alOneh alOneh force-pushed the feature/vuetify-generator branch from 703c745 to 0a7d15d Compare November 12, 2019 22:04
@soyuka soyuka requested a review from Gregcop1 November 13, 2019 10:42
@sblum51
Copy link

sblum51 commented Nov 14, 2019

Hello, I would like to help, I fetched the PR branch, how to run the node binary locally (instead of the command npx @api-platform/client-generator) thanks ! (As user of api-platform and vuetify for 2y I'm very glad to see this PR)

@dunglas
Copy link
Member

dunglas commented Nov 14, 2019

Simply run ./src/index.js!

@sblum51
Copy link

sblum51 commented Nov 14, 2019

Yes I was very sleepy when I tried yesterday and worked this morning after coffee, thanks !

@dunglas dunglas merged commit b71e900 into api-platform:master Nov 14, 2019
@dunglas
Copy link
Member

dunglas commented Nov 14, 2019

Thanks @alOneh

@sblum51
Copy link

sblum51 commented Nov 14, 2019

Thanks for the merge. For me it doesn't work "out of the box" but I will send PR asap in order to solve that.

@alOneh
Copy link
Contributor Author

alOneh commented Nov 14, 2019

What's the problem inside @guizmo51?

@sblum51
Copy link

sblum51 commented Nov 15, 2019

Hi @alOneh thanks for your work and I really like to use Vuetify and never found the time to add it to the client-generator lib.
I tried again with the master branch of client-generator
The creation of the main.js, router/index.js store/index.js differ of the vue.js. Need to add vue-i18n also.

I got issues with the "Lists" the default order params is empty and the API receives this empty params (triggers a 500 error)
For the moment I also have issues with the store and the form.

@alOneh
Copy link
Contributor Author

alOneh commented Nov 15, 2019

@guizmo51 Ok I check with the master branch and find issues, let me fix them quickly. I also update the documentation to reflect some changes and missing parts.

@sblum51
Copy link

sblum51 commented Nov 15, 2019

I plan to help you, it's the OSS :)
[Todo list] (or I will update it)
In the message send by the generator

  • path of [serviceNAME] from '../services/review'; path of [serviceNAME] from './services/review';
    In the help text of the generator, add vuetify in the list

@alOneh
Copy link
Contributor Author

alOneh commented Nov 15, 2019

@guizmo51 to keep track of them I create an issue : #190

@alOneh alOneh deleted the feature/vuetify-generator branch November 15, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants