Templates for typescript react application #192
Conversation
| @@ -2,7 +2,7 @@ import AdminOnRestGenerator from "./generators/AdminOnRestGenerator"; | |||
| import NextGenerator from "./generators/NextGenerator"; | |||
| import ReactGenerator from "./generators/ReactGenerator"; | |||
| import ReactNativeGenerator from "./generators/ReactNativeGenerator"; | |||
| import TypescriptInterfaceGenerator from "./generators/TypescriptInterfaceGenerator"; | |||
There was a problem hiding this comment.
Interfaces generator is useful in certain cases, possible to keep it?
There was a problem hiding this comment.
Yes, of course. I'll make changes soon
|
It would be nice if we could find a way to merge the code between the JS React, TypeScript React and TypeScript Next generators. It would simplify the maintenance. Maybe could we support only TypeScript for instance? WDYT? /cc @Gregcop1 |
|
@dunglas did you made any decision on merging the codebase for js/ts react/vue/next? I'm currently writing implementation for case that will generate Vue.js + Vuex in Typescript and was wondering if I even should bother with PR if the whole base is going to be rewritten. |
|
For now we'll keep the generators separated (it's easier to maintain). PR welcome! In the end, I would like to be able to "generate" readable JS code from the TypeScript code, but I'm not sure if it is possible. Another option could be to deprecate vanilla JS generators at some point and only support TS (users could still remove type definitions if they don't want to use them). |
|
We will only use #193 to reduce the burden of maintenance. |
I used react templates as base for typescript templates.