Skip to content

bootstrap 4 buttons #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2017
Merged

bootstrap 4 buttons #51

merged 1 commit into from
Oct 9, 2017

Conversation

mysiar
Copy link
Member

@mysiar mysiar commented Oct 9, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

bootstrap 4 button classes

@mysiar mysiar changed the title fix bootstrap 4 buttons Oct 9, 2017
@mysiar mysiar merged commit c7af287 into api-platform:master Oct 9, 2017
@mysiar mysiar deleted the bootstrap4 branch October 9, 2017 18:48
@dunglas
Copy link
Member

dunglas commented Oct 9, 2017

Why does changes?

@dunglas
Copy link
Member

dunglas commented Oct 9, 2017

Ok btn-default has been removed, got it. But according to: https://getbootstrap.com/docs/4.0/migration/#buttons

Renamed .btn-default to .btn-secondary.

@mysiar
Copy link
Member Author

mysiar commented Oct 9, 2017

Made default primary and submit success for colors :)

@dunglas
Copy link
Member

dunglas commented Oct 9, 2017

Ok great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mysiar @dunglas