admin-on-rest generator

[mysiar]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
License	MIT

[dunglas]

It will double the work and the maintenance with api-platform/admin...

[mysiar]

I needed it so created due to some custom endpoints that api-platform/admin couldn't serve

[mysiar]

@mauchede please review this PR

[mauchede]

It could be removed.

[mauchede]

How can we use resource-import.js? When I tried your PR, I created an Admin node and I used directly my resource:

import React from 'react';
import { Admin } from 'admin-on-rest';
import { hydraClient } from '@api-platform/admin';
import gallery from './admin/resources/gallery';

export default (props) => {
  return (
      <Admin restClient={hydraClient({entrypoint: 'http://127.0.0.1:8000'})}>
        {gallery}
      </Admin>
  );
};

It worked fine, but if I tried to use resource-import.js:

import React from 'react';
import { Admin } from 'admin-on-rest';
import { hydraClient } from '@api-platform/admin';
import { gallery } from './admin/resource-import';

export default (props) => {
  return (
      <Admin restClient={hydraClient({entrypoint: 'http://127.0.0.1:8000'})}>
        {gallery}
      </Admin>
  );
};

It did not work because resource-import did not export resources. In that case, we have two solutions:

1. Export each resource in resource-import with the following syntax:

export { default as gallery } from './resources/gallery';

2. Export only an array of resources:

export default [
  gallery
];

IMO, this solution will be better for DX because we just have to use this array in Admin rendering:

import React from 'react';
import { Admin } from 'admin-on-rest';
import { hydraClient } from '@api-platform/admin';
import resources from './admin/resource-import';

export default (props) => {
  return (
      <Admin restClient={hydraClient({entrypoint: 'http://127.0.0.1:8000'})}>
        {resources}
      </Admin>
  );
};

[mysiar]

I like the idea 2 but how to get in template the export of the array ?

right now I fixed it with idea 1

[mysiar]

there is another solution to get all imports at once

import  * as resources from "resource-import";
...
  <Admin
     ...
   >
     {Object.keys(resources).map( (key) => resources[key] )}
  </Admin>

@mauchede WDYT ?

[mauchede]

It seems good!