Isolate the PHAR with PHP-Scoper #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schema.yml
is provided with the expected filescomposer.lock
: if used as a library this does not matter and the tests don't rely on it (acomposer update is ran
). However for shipping the PHAR, specific versions are expected. This is also required by PHP-Scoper as some patches are required and they are by nature extremely brittle. A way to avoid that would be to patch PHP-CS-Fixer directly but that's another story.Right now the build is failing due to an error in the PHAR. However as it works with the isolated deps (e.g. if I take
build/bin/schema
instead ofschema.phar
) it works so it seems that the error is not coming from those changes.