Add e2e tests #106
Merged
Add e2e tests #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Oct 13, 2017
.travis.yml
Outdated
| - | | ||
| if [[ ! $deps && $TRAVIS_PHP_VERSION = "7.1" ]]; then | ||
| composer install --no-dev --prefer-dist --no-progress --no-suggest --ansi; | ||
| composer dump-autoload --classmap-authoritative --no-dev; |
There was a problem hiding this comment.
You can merge both lines (composer install --no-dev --prefer-dist --classmap-authoritative --no-progress --no-suggest --ansi)
|
|
||
| script: | ||
| - if [[ $coverage = 1 ]]; then phpdbg -qrr phpunit-6.3.phar --coverage-clover build/logs/clover.xml; else php phpunit-6.3.phar; fi | ||
| - if [[ $lint = 1 ]]; then php php-cs-fixer.phar fix --dry-run --diff --no-ansi; fi |
There was a problem hiding this comment.
the tests/e2e directory must be excluded in .php_cs.dist.
|
@dunglas build green & PR ready for review |
dunglas
approved these changes
Oct 13, 2017
|
Thank you very much @theofidry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset of #105. Instead of doing the jump of adding e2e tests with the PHAR + the scoping, this PR just takes care of the PHAR e2e tests :)