Add support for entity operation annotations #144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properties that are superseded or superseded by a property were both all created, causing duplicate properties in classes. For example, property `$award` supersedes `$award` in `CreativeWork` (https://schema.org/award) but both of these properties were generated in the class: ``` /** * @var string|null an award won by or for this item * * @Orm\Column(type="text", nullable=true) * @ApiProperty(iri="http://schema.org/award") */ private $award; /** * @var string|null awards won by or for this item * * @Orm\Column(type="text", nullable=true) */ protected $award; ``` This change uses the property which has been declared as superseding.
… no comma!! Please, consider this fix Hi! Ended up with an annotation like @Orm\Column(type="text"unique=true) No comma!! Please, consider this fix
Fix another phpcs sin, sorry
Add inversedBy and mappedBy fix api-platform#112
Ended up with an annotation like @Orm\Column(type="text"unique=true),…
…om-fields use nullable property for customfields
…mplate-dirs Add custom twig template dirs
Travis: remove sudo: false
…form#168) * Composer update, not install, for tci coverage Travis CI build for php 7.2 with `coverage=1 lint=1` was failing when executing `./bin/compile` at the end of the script stage. Before this command, `composer update` is called which updates the lock file with dependencies in way which causes namespace errors. * Adapt e2e files to test expectancies Builds were still failing after 0411921 because since they started failing a while back, the class files for the 2e2 tests stopped matching the produced classes: The CI process never reached the point where they were tested. This commit adapts the files accordingly.
Setting up a config where a child class inherits its parent's properties through class inheritance did not work. The logic in TypesGenerator handled implicit inheritance based on whether the parent's properties key was not set or not an array, but did not account for empty arrays. Also added tests for these implicit and explicit cases.
Use superseding props over which they supersede
Remove instruction to ping maintainers
…een-orm-annotation-elements Fix tests: Put space back after comma between ORM annotation properties
…nheritance Correct implicit and explicit property inheritance
|
First of all, sorry for the late reply. Could you rebase it please? It should fix the test. |
Add support for custom columnPrefix
non-int value in the execute command will be deprecated
Replacement of Twig depreciation
….com:toby-griffiths/schema-generator into add-support-for-entity-operation-annotations
|
@dunglas Done! |
|
There is a problem with the rebase isn't it? |
|
I looked at the log & looks like style issues, which I've corrected. Have I missed something else? I think all the tests are passing now. |
|
The PR contains 35 commits, it looks weird |
|
Hmmm… OK. Perhaps it's easier if I start again. |
toby-griffiths
deleted the
add-support-for-entity-operation-annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of PR #110 for changes rebased onto current master…
I've added the possibility to add the following to a type definition to support operation annotations…
This will probably want documenting too, but not got time to do this right now. I've made a reminder to do this if someone else doesn;t get to it before I do.