Use superseding props over which they supersede #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properties that are superseded or superseded by a property were both all created, causing duplicate properties in classes. For example, property `$award` supersedes `$award` in `CreativeWork` (https://schema.org/award) but both of these properties were generated in the class: ``` /** * @var string|null an award won by or for this item * * @Orm\Column(type="text", nullable=true) * @ApiProperty(iri="http://schema.org/award") */ private $award; /** * @var string|null awards won by or for this item * * @Orm\Column(type="text", nullable=true) */ protected $award; ``` This change uses the property which has been declared as superseding.
soyuka
approved these changes
Jun 4, 2019
dunglas
approved these changes
Jul 24, 2019
|
Thanks! And sorry for the delay. |
|
@dunglas Awesome! Thanks 🎉 |
This was referenced Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To maintainers @dunglas, @sroze or @theofidry
Properties that are superseded or superseded by a property were both all
created, causing duplicate properties in classes.
For example, property
$awardsupersedes$awardinCreativeWork(https://schema.org/award) but both of these properties were generated
in the class:
This change uses the property which has been declared as superseding.