-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for comments #139
Comments
Hey @xanderiel I am trying to avoid introducing comments to the API Blueprint – as I believe that could lead to blueprints fragmentation. However I would like to know about your use case for them – perhaps we will be able to address it in a different way ? |
Please reopen with some additional input if needed. |
👍 |
@toobulkeh Is your WIP about the description or the layout of APIs ? Could there be another way to satisfy it? |
Hi there, I think the possibility to create comments is really important. Below 2 use case:
I refuse to create 2 separate documentations, as it is the best way to async docs. Instead, I am using comments to indicate parts that are to be preprocessed before sent to apiary. example:
A script preprocesses the input.apib file and removes the parts for the public. However, we are able to have an internal doc that documents this endpoint. On my side, the works both on apiary and local, and it is a blessing ;). However, I just wish that in code parts, it was not considered as a syntax error but as an intended design. |
We are working on a larger api spec and use gulp inclusion, templates, hercule etc. Comments would help explain what's happening, why and how. |
@weaselmetal that makes sense |
+1 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
+1 FYI, we'd like to put a reference to the constants from our codebase to the API blueprint, so that when we change the constant, we can track its presence in the API blueprint. For example:
|
+1 |
7 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
👍 This is really useful while writing documentation from scratch. As far as i'm aware there's still no way of making comments for myself to remind me what resources are in each route, so that I know what I need to include when getting around to writing docs for them & don't miss anything. E.g:
Only way to do it right now is to fill the documentation with useless information for developers...or just not do it and hope for the best 😅 |
For the WIP, the comment section will be very useful. |
➕ 1️⃣ I'd like to be able to leave comments because I want my teammates and future maintainers of the documentation to know what code the docs are based on, for example: |
I am using apiary for both internal specification for our devs building the api and for providing documentation to devs at other companies consuming our api. |
+1 |
1 similar comment
+1 |
+1 |
2 similar comments
+1 |
+1 |
@weaselmetal wrote:
If you compile blueprint from smaller files, then you can remove comments at the end of build process. A JavaScript-compatible regular expression for HTML comment is |
+1 |
We understand this is a wanted feature, but next time please use GitHub Reactions to express your feelings. Thanks! ✨ By the way, one of the benefits is we can sort by the reactions: |
I'd like to provide some insight into what the next steps are for this feature. Right now we are constrained by our underlying markdown parser (Sundown) which has various limitations, including #207. Sundown has not been maintained since 2012 other than our changes in our own fork. Our long term plan is to handle parsing ourselves in the API Blueprint parser which will give us a lot more control and unlock adding features like #139 and #207. While I am not able to give any timeline, it is something we are actively working towards, there are a lot of refactoring going on at the moment which is going to allow us to move forward in this area. Once the refactoring is completely we will be able to move much faster. I appreciate all of your patience. |
Thank you for the update @kylef. |
Here's a working example how to remove HTML comments ( |
Any updates guys? Would be great to know if/when this feature will be included to the official roadmap. |
Past sunset then 🌞 |
For me a great usecase would be to dump the API call that made the code sample, so that it's repeatable when the response changes.
|
Hello there, |
From what I saw on apiary.io I can't comment out blocks of the documentation which is very important for me.
Even putting HTML style
<!-- ... -->
comments doesn't work.The text was updated successfully, but these errors were encountered: