This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Use newer node version #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylef
reviewed
Feb 12, 2017
| - node --version | ||
| - npm install --python=python2 -g dredd | ||
| - npm install --python=python2 -g dredd --no-optional |
There was a problem hiding this comment.
I assume the --python=python2 was for Protagonist/Drafter's configure script. Since you've added --no-optional and pure drafter JS would be used, you may be able to remove --python=python2.
|
Yes, that's a good point!
…On Sun, 12 Feb 2017 at 09:49, Kyle Fuller ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#30 (review)>
:
> - node --version
-- npm install --python=python2 -g dredd
+- npm install --python=python2 -g dredd --no-optional
I assume the --python=python2 was for Protagonist/Drafter's configure
script. Since you've added --no-optional and pure drafter JS would be
used, you may be able to remove --python=python2.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARTMeIafkOhx25our0Sb-lZwLnUfs41ks5rbsetgaJpZM4L9kuH>
.
|
honzajavorek
added a commit
that referenced
this pull request
Feb 13, 2017
The Python version was specified to ensure node-gyp compilation works (it supports Python 2 only). We use --no-optional now to speed up the installation on CI, which means no compilation should take place at all. In that case, specifying the Python version is redundant. Based on @kylef's comment under #30.
honzajavorek
added a commit
that referenced
this pull request
Feb 13, 2017
The Python version was specified to ensure node-gyp compilation works (it supports Python 2 only). We use --no-optional now to speed up the installation on CI, which means no compilation should take place at all. In that case, specifying the Python version is redundant. Based on @kylef's comment under #30.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soon Dredd won't support node versions 0.10 and 0.12: apiaryio/dredd#716 Those are ancient and officially dead now (not supported by node maintainers anymore). Node setup for Travis CI builds of different languages (Ruby, Python, Perl, PHP, ...) is outdated and uses these dead versions by default. This PR ensures the build will install Dredd with correct node version. The
nodealias in thenvm install nodecommand points to the latest node version.The
--no-optionalflag in Dredd installation command skips C++11 compilation (speeds up the build).