-
Notifications
You must be signed in to change notification settings - Fork 130
fix: Always clear cache when on MCP page to help with redirect issue #1801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview for this PR was built for commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (tho not that great at React :D)
Preview for this PR was built for commit |
@TC-MO I made a small update to the text. We would like to gently encourage people to star the GitHub page. I tried adding a badge with the star count, but it did not look great, so I decided to include it as plain text instead.
|
Preview for this PR was built for commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes suggested, but also broader discussion about placement of both notes
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Preview for this PR was built for commit |
@TC-MO I took care of your comments, but I believe, once you'll revisit the document, you might change it anyway (to find a better place) |
Preview for this PR was built for commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I don't mind where the script is implemented.
Alternatively, we have this JS script added to all the pages, where we do all sorts of random JS quirks (outside of react):
https://github.com/apify/apify-docs/blob/master/apify-docs-theme/static/js/custom.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small visual nit: I think it makes sense to use emphasis with italics within the quick start note otherwise, LGTM
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Preview for this PR was built for commit |
Preview for this PR was built for commit |
@B4nan thanks. I've moved to If you can, please give a quick look and we can release it. |
Let's merge this and see: |
based 😎 |
…pify#1801) Always clear cache when on MCP page to help with redirect issues. Previously, mcp.apify.com had a 301 redirect to this docs page, which was wrong. Many users have this redirect cached in their browsers, so they can't access the new MCP UI. This helps with their cached redirect, allowing them to access mcp.apify.com @B4nan is there is a better place to put the code than in the src/theme/layout? Kudos to @JJetmar FYI @MQ37 close apify/apify-mcp-server#129 close https://github.com/apify/ai-team/issues/33 EDIT: Remove this fix after some time: apify#1802 --------- Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Always clear cache when on MCP page to help with redirect issues.
Previously, mcp.apify.com had a 301 redirect to this docs page, which was wrong.
Many users have this redirect cached in their browsers, so they can't access the new MCP UI.
This helps with their cached redirect, allowing them to access mcp.apify.com
@B4nan is there is a better place to put the code than in the src/theme/layout?
Kudos to @JJetmar
FYI @MQ37
close apify/apify-mcp-server#129
close https://github.com/apify/ai-team/issues/33
EDIT: Remove this fix after some time: #1802