fix: nginx configuration; add nginx linter #1935
Conversation
github-actions
bot
added
the
t-infra
|
Preview for this PR was built for commit |
lukasmrtvy
changed the title
|
Preview for this PR was built for commit |
|
Can I get some context for this? I guess we are now validating the changes to the nginx config as part of PR checks, instead of only finding out about it in the private repository? The PR check fails now. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Comment @cursor review or bugbot run to trigger another review on this PR
| - name: Test Nginx configuration | ||
| run: | | ||
| echo "http { include 'nginx.conf'; }" > default.conf | ||
| nginx -t -c $(pwd)/default.conf |
There was a problem hiding this comment.
Bug: Invalid Nginx Image Version & Incorrect Config Path
The Nginx configuration test workflow encounters two problems. The nginx:1.29.1-alpine-slim Docker image version is invalid; Nginx stable versions are typically in the 1.2x.x range, preventing the image from being pulled. Also, the include 'nginx.conf' directive uses a relative path, which Nginx resolves from its default configuration directory, not the current working directory, so it won't find the nginx.conf file.
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Fixed. The last deployment ( https://github.com/apify/apify-docs-private/actions/runs/17827556817/job/50684203179 ) failed because of the wrong configuration introduced in #1933, thus the validation workflow :) |
seyhello
added
the
validated
No description provided.