Skip to content

fix: nginx configuration; add nginx linter #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2025
Merged

fix: nginx configuration; add nginx linter #1935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60c6d48
fix: nginx configuration
lukasmrtvy Sep 18, 2025
db76e16
fix: add nginx test configuration
lukasmrtvy Sep 18, 2025
e10eca1
fix
lukasmrtvy Sep 18, 2025
79d9dec
fix: explicit image repository
lukasmrtvy Sep 18, 2025
5f89724
fix: add events stanza
lukasmrtvy Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/nginx.conf-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Nginx configuration test

on:
pull_request:
paths:
- nginx.conf

jobs:
nginx-test-job:
runs-on: ubuntu-latest
container:
image: docker.io/library/nginx:1.28.0-alpine-slim
steps:
- name: Checkout repository
uses: actions/checkout@v5
- name: Test Nginx configuration
run: |
cat > default.conf <<EOF
http {
include 'nginx.conf';
}
events {}
EOF
nginx -t -c $(pwd)/default.conf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Invalid Nginx Image Version & Incorrect Config Path

The Nginx configuration test workflow encounters two problems. The nginx:1.29.1-alpine-slim Docker image version is invalid; Nginx stable versions are typically in the 1.2x.x range, preventing the image from being pulled. Also, the include 'nginx.conf' directive uses a relative path, which Nginx resolves from its default configuration directory, not the current working directory, so it won't find the nginx.conf file.

Fix in Cursor Fix in Web

2 changes: 1 addition & 1 deletion nginx.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ server {
rewrite ^/academy/get-most-of-actors$ /academy/actor-marketing-playbook permanent;

# Misc
; rewrite ^/platform/integrations/llama$ /platform/integrations/llama-index permanent;
rewrite ^/platform/integrations/llama$ /platform/integrations/llama-index permanent;

}

Expand Down
Loading