feat: Increased length of actor name #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrunkat
approved these changes
Jun 3, 2021
|
I don't understand the problem much, but why would an actor name, that's in the path part of URL need to be only 63 chars? Doesn't everyone use longer strings? |
|
e.g. GitHub uses 100 chars for repository names |
|
We discussed it with Mara and decided to go with DNS safe string to do not break in the future. |
|
Cool, will merge it when I get a confirmation from @B4nan that the release process is fixed. |
|
Only way to find out is to merge it :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased the length of actor name into 63 chars (DNS safe string length)