Skip to content

Conversation

m-murasovs
Copy link
Contributor

Replacing the git-url-parse package in the markdown renderers with native Node URL parsing (it's not compatible with Safari).

@m-murasovs m-murasovs added the bug Something isn't working. label Jul 13, 2021
@m-murasovs m-murasovs added this to the 17th Sprint - Web team milestone Jul 13, 2021
@m-murasovs m-murasovs requested a review from jbartadev July 13, 2021 14:08
@m-murasovs m-murasovs self-assigned this Jul 13, 2021
Copy link
Member

@jbartadev jbartadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an easy replacement. Small comments.

The git-url-parse package isn't used anymore in this package so please remove it from dependency too.

@m-murasovs m-murasovs requested a review from jbartadev July 14, 2021 11:16
Copy link
Member

@jbartadev jbartadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@m-murasovs m-murasovs merged commit d7340f4 into master Jul 14, 2021
@m-murasovs m-murasovs deleted the fix/marked-broken-dependency branch July 14, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants