Skip to content

Conversation

valekjo
Copy link
Member

@valekjo valekjo commented Aug 23, 2021

BREAKING CHANGE: update ajv to v8 and set it as peerDependency

BREAKING_CHANGE: update ajv to v8 and set it as peerDependency
@valekjo valekjo requested a review from B4nan August 23, 2021 09:37
@github-actions github-actions bot added this to the 20th Sprint - Console team milestone Aug 23, 2021
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just some nitpicks

btw the BREAKING CHANGE in the commit message is with space, not underscore. when merging, ensure the commit message contains it - otherwise it won't be marked as BC and will be just a minor version bump (it is about the resulting commit message in master, not about PR description, i know gh sometimes don't copy it automatically to the field).

* This function validates given input schema first just for basic structure then each field one by one and
* finally fully against the whole schema.
*
q: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this is not intentional?

"escaya": "^0.0.61"
},
"peerDependencies": {
"ajv": "^8.6.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peer deps are usually just about major versions, so as long as we know there are no major issues with 8.0.0, i'd suggest to use that instead

Suggested change
"ajv": "^8.6.2"
"ajv": "^8.0.0"

@valekjo valekjo merged commit e7693f3 into master Aug 23, 2021
@valekjo valekjo deleted the feature/ajv-package-update branch August 23, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants