feat: dual (native) ESM/CJS support all the packages

[vladfrangu]

While all the compiled code looks fine and functional, testing would still be needed to ensure it still works correctly

[B4nan]

I guess we should require node 14 and ship major versions of everything

[vladfrangu]

Ouch... Shapeshift is node 16+ only it seems... I thought nodejs 14 also had it. Might have to either experiment with ow or make shapeshift compatible with node 14

[B4nan]

Personally i dont mind node 16 either, those are internal packages so as long as we run things on node 16 internally… but i am not sure about that tbh, i would expect older version

[vladfrangu]

I think a huge chunk internally is still on node 14, so yeah.. will have to look into this

[vladfrangu]

Actually, I don't get why the CI is failing on node 14, as it supports ?. and ??...

Misread the stack, its the ??= that crashes it (and what was added in node 15+)

[vladfrangu]

We made shapeshift be nodejs 14+ compatible, and I feel like we could drop the nodejs 12 CI here, especially since it's no longer even supported by node. Thoughts?

[mnmkng]

@fnesveda @gippy Would be great if you guys could chime in. I'm not sure if this won't break anything on the platform :)

[vladfrangu]

If platform depends in any way on the ow errors, it will break something. Otherwise it should just work the same, but I do wonder if it can be tested somehow 👀

[mnmkng]

Platform uses Meteor which uses its own transpilation. Anything can go wrong 😀

[fnesveda]

@vladfrangu @mnmkng So what's actually the goal of this PR? Would be nice to get some short description of what has changed instead of just a review request out of the blue, so we don't have to play detective across 43 changed files.

[mnmkng]

@fnesveda It's a change to use native ESM imports and modules instead of CJS AFAIK.

I added you because I had no idea if Platform even supports ESM.

[vladfrangu]

The PR makes all the modules in here dual-compile to ESM and CJS, to provide native ESM for those that use ESM instead of a light wrapper with gen-esm-wrapper. It shouldn't change anything in terms of code execution, platform will probably still import the CJS file (we can also build browser compatible bundles if it helps at all, to have them globally available via ApifyConstants for example) if it respects the package.json export declarations 😄

[fnesveda]

If it still builds CJS versions as well, and they are the default under main in package.json, then it should be importable / requireable on the platform.

We'll just have to change a few imports since all the files are now bundled, and we can't import from them directly, but nothing major.

Could you release this as a major version, just to make sure we don't accidentally update the packages with Renovate bot etc.?

[fnesveda]

Also CC @jbartadev we'll probably have to update web to Node 14+ because of this (and other reasons).

[B4nan]

Let's see how it works... 🤞

[B4nan]

Looks like it works fine, already added to crawlee, E2E tests are passing including on platform.