feat(input_schema): add isSecret flag into the sting property

[drobnikj]

Add support for secure input values by adding isSecret flag into the sting property

The flag is optional, so the change is not breaking.

EDIT:

I improved validation, if isSecret is true fields:
['minLength', 'maxLength','default', 'prefill', 'pattern']
are not in string type definition and editor is only enum for
['textfield', 'textarea', 'hidden']

[mtrunkat]

How does it going to work with other options such as:

• editor? We could display the correct editor later on in the modal? This is useful, for example, for some secret JSON values.
• we should probably disable max/min length as it could collide with encrypted data or no?

[drobnikj]

@mtrunkat I cannot find any way how to do conditional fields in json schema. As you said, it would be good, but not sure how to do it in schema.

As Franta mention we can use draf-07 I was thinking only for draft-04 🤦

[fnesveda]

@drobnikj JSON schema now supports if-then-else (since draft-07), maybe that would work?
https://json-schema.org/understanding-json-schema/reference/conditionals.html#if-then-else

[fnesveda]

Also, if the conditional fields in the schema are possible, maybe we should disable prefill and default for secret fields too, it would make the frontend code a lot easier, and I don't think it really hurts any usecase.

[drobnikj]

I have quite hard times finding way how to do it. It is a little bit breakneck, but it should work.

[drobnikj]

I updated the schema, please check again @fnesveda @mtrunkat

[fnesveda]

Uff, nice job!

I thought it would be easier, but the additionalProperties rule is making it complicated.