feat(consts,log): add support for reading log level from env var #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnesveda
added
enhancement
github-actions
bot
added
the
t-core-services
fnesveda
force-pushed
the
feature/read-log-format-from-env-var
branch
from
7ad3280 to
ea3adc7
Compare
fnesveda
changed the title
jirimoravcik
approved these changes
Oct 4, 2022
drobnikj
approved these changes
Oct 5, 2022
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to get rid of using
configureLogger()and configure the log just via environment variables, so we can override the log level and format easier.This adds support for specifying the log format via environment variable
APIFY_LOG_FORMAT, with the default beingTEXT(so the default behavior is not changed, and this is not a breaking change).