feat(input_secrets): add new package to encrypt and decrypt input secrets #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-core-services
fnesveda
approved these changes
Oct 5, 2022
jirimoravcik
approved these changes
Oct 6, 2022
| @@ -0,0 +1,46 @@ | |||
| { | |||
| "name": "@apify/input_secrets", | |||
There was a problem hiding this comment.
why underscore in the name?
There was a problem hiding this comment.
Why not? I check other packages in @apify/ and these have same separator.
https://github.com/apify/apify-shared-js/blob/master/packages/image_proxy_client/package.json#L2
There was a problem hiding this comment.
It needs to be same as folder path because https://github.com/apify/apify-shared-js/blob/master/tsconfig.json#L6
There was a problem hiding this comment.
ok, understandable :D still it's common to have a dash instead of underscore
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the code from https://github.com/apify/apify-core/pull/8266
We need to use
decryptInputSecretsand in the futureencryptInputSecretsin apify-sdk, so I move it here.