Skip to content

Conversation

@katacek
Copy link
Member

@katacek katacek commented May 12, 2023

Fixing wrong proxygroup validation (if the group is array of strings), there is a connected PR for the message

Working for our case, I have checked also for general input schema, if it returns correct values for different schema amd it seems ok.

Screenshot 2023-05-15 at 13 23 46

Screenshot 2023-05-15 at 13 41 51

@katacek katacek added bug Something isn't working. adhoc Ad-hoc unplanned task added during the sprint. labels May 12, 2023
@katacek katacek added this to the 63rd sprint - Console team milestone May 12, 2023
@katacek katacek self-assigned this May 12, 2023
@github-actions github-actions bot added the t-console Issues with this label are in the ownership of the console team. label May 12, 2023
@katacek katacek requested a review from fnesveda May 12, 2023 13:13
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to solve it so simply, but I think it won't work unfortunately 🙁

@katacek katacek marked this pull request as ready for review May 15, 2023 11:59
@katacek katacek requested review from fnesveda and gippy May 15, 2023 12:05
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@katacek katacek merged commit 1b3a118 into master May 18, 2023
@katacek katacek deleted the fix/input-schema-proxy-group-validation branch May 18, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working. t-console Issues with this label are in the ownership of the console team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants