feat: add more ACTOR_ env vars, add a test, rename ENV_VARS #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-core-services
fnesveda
requested changes
Jul 11, 2023
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
fnesveda
approved these changes
Jul 11, 2023
fnesveda
approved these changes
Jul 11, 2023
drobnikj
approved these changes
Jul 11, 2023
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added more actor env vars based on updated https://github.com/apify/actor-specs/#environment-variables
I added a test that checks if all actor env vars begin with
ACTOR_.I renamed
ENV_VARStoAPIFY_ENV_VARSand created a newENV_VARSvariable that just copies the values for backwards compatibility. Also added a test to check if this works correctly.