Skip to content

feat: improve consts related to env vars #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2023
Merged

feat: improve consts related to env vars #405

merged 1 commit into from
Jul 17, 2023

Conversation

@jirimoravcik
Copy link
Member

@jirimoravcik jirimoravcik commented Jul 13, 2023 •
edited
Loading

Another round of improvements:

  • split of LOCAL_ENV_VARS into LOCAL_APIFY_ENV_VARS and LOCAL_ACTOR_ENV_VARS. LOCAL_APIFY_ENV_VARS still shadows LOCAL_ACTOR_ENV_VARS with the APIFY_ equivalents.
  • Added tests checking LOCAL_APIFY_ENV_VARS and LOCAL_ACTOR_ENV_VARS
  • LOCAL_ENV_VARS deprecated in favor of LOCAL_APIFY_ENV_VARS, but still shadowed.
  • APIFY_ENV_VARS sorted alphabetically, grouped the deprecated env vars below with comments.
  • Added 4 environment variables that were missing: METAMORPH_AFTER_SLEEP_MILLIS, APIFY_PERSIST_STATE_INTERVAL_MILLIS, APIFY_SYSTEM_INFO_INTERVAL_MILLIS, APIFY_PURGE_ON_START
  • Extended INTEGER_ENV_VARS with Actor env vars and also added some Apify env vars that were missing

@github-actions github-actions bot added this to the 67th sprint - Platform team milestone Jul 13, 2023
@github-actions github-actions bot added t-core-services Issues with this label are in the ownership of the core services team. tested Temporary label used only programatically for some analytics. labels Jul 13, 2023
@jirimoravcik jirimoravcik merged commit dba0675 into master Jul 17, 2023
@jirimoravcik jirimoravcik deleted the feature/local-env-vars-grooming branch July 17, 2023 07:20
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fnesveda fnesveda fnesveda approved these changes

@drobnikj drobnikj drobnikj approved these changes

Assignees

@jirimoravcik jirimoravcik

Labels

t-core-services Issues with this label are in the ownership of the core services team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Milestone

67th sprint - Platform team

Development

Successfully merging this pull request may close these issues.

3 participants

@jirimoravcik @fnesveda @drobnikj