Skip to content

Conversation

mfori
Copy link
Member

@mfori mfori commented Jul 8, 2025

No description provided.

@mfori mfori requested review from Copilot and gippy July 8, 2025 08:17
@mfori mfori self-assigned this Jul 8, 2025
@mfori mfori added adhoc Ad-hoc unplanned task added during the sprint. t-console Issues with this label are in the ownership of the console team. labels Jul 8, 2025
@github-actions github-actions bot added this to the 118th sprint - Console team milestone Jul 8, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts string secret encryption to the legacy format until the SDK supports the new format.

  • Add a branch for string values to use the old encrypted string form (prefix:password:value)
  • Include a TODO to remove this fallback once the SDK is updated
Comments suppressed due to low confidence (3)

packages/input_secrets/src/input_secrets.ts:51

  • There's a new branch handling string values; consider adding or updating unit tests to cover this legacy encryption path.
    if (typeof value === 'string') {

packages/input_secrets/src/input_secrets.ts:49

  • [nitpick] The TODO comment would be clearer if it referenced a specific SDK version or tracking issue to know when it can be removed.
    // TODO to make string encryption compatible with current SDK, we need to use the old form.

packages/input_secrets/src/input_secrets.ts:52

  • [nitpick] Destructuring here is fine, but consider validating that encryptedPassword and encryptedValue are non-empty strings before formatting the return value.
        const { encryptedValue, encryptedPassword } = publicEncrypt({ value, publicKey });

@mfori mfori merged commit 4309a04 into master Jul 8, 2025
9 of 10 checks passed
@mfori mfori deleted the fix/input-secret-string-form branch July 8, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-console Issues with this label are in the ownership of the console team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants