Skip to content

fix(input_secret): For string secret revert to old form until SDK is updated #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

fix(input_secret): For string secret revert to old form until SDK is updated #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/input_secrets/src/input_secrets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ export function encryptInputSecretValue<T extends string | object>(
ow(publicKey, ow.object.instanceOf(KeyObject));
ow(schema, ow.optional.object);

// TODO to make string encryption compatible with current SDK, we need to use the old form.
// Remove this once SDK is updated to use the new form
if (typeof value === 'string') {
const { encryptedValue, encryptedPassword } = publicEncrypt({ value, publicKey });
return `${ENCRYPTED_STRING_VALUE_PREFIX}:${encryptedPassword}:${encryptedValue}`;
}

const schemaHash = schema ? getFieldSchemaHash(schema) : null;

// We are encrypting the value as a JSON string, so we need to stringify it first.
Expand Down