Skip to content

Improved request parameters mapping #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2018
Merged

Improved request parameters mapping #61

merged 2 commits into from
Oct 4, 2018

Conversation

@mabar
Copy link
Contributor

@mabar mabar commented Oct 3, 2018 •
edited
Loading

  • Move null checks from individual mappers into RequestParameterMapping
  • Unify request parameters mapping error messages

@mabar mabar changed the title WIP: Improved request parameters mapping Improved request parameters mapping Oct 3, 2018
@mabar mabar requested a review from f3l1x October 4, 2018 08:01
@f3l1x f3l1x merged commit f3e77d3 into master Oct 4, 2018
@f3l1x
Copy link
Member

f3l1x commented Oct 4, 2018

👍

@f3l1x f3l1x deleted the improve-mapping branch October 4, 2018 08:36
@f3l1x f3l1x added this to the v0.4 milestone Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f3l1x f3l1x Awaiting requested review from f3l1x

Assignees

No one assigned

Labels

None yet

Milestone

v0.4

Development

Successfully merging this pull request may close these issues.

3 participants

@mabar @f3l1x