Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install missing sha.js dependency #2283

Merged

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Apr 26, 2021

Related to #2274, which removes a dependency on apollo-env which transitively required this package (presumably, unconfirmed but I will validate).

This also adds typings to the require() statements for the respective modules.

Related to, and unblocks a fix for apollographql/federation#693

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

Related to apollographql#2274, which removes a dependency on apollo-env which
transitively required this package (presumably, unconfirmed but I
will validate).

This also adds typings to the require() statements for the
respective modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants