fix: Dependency issues introduced by changes to underlying tooling packages #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this was only needed for compatibility with old versions of Node and hasn't been required since #311. That PR removed the explicit dependency on core-js from federation-js/package.json, but didn't remove this import, which breaks build scenarios that are more strict about dependency declaration. Fixes #692.
trevor-scheer
changed the title
glasser
commented
Apr 26, 2021
abernix
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was only needed for compatibility with old versions of Node and hasn't been required since #311. That PR removed the explicit dependency on
core-jsfromfederation-js/package.json, but didn't remove this import, which breaks build scenarios that are more strict about dependency declaration.Update
apollo-graphqltolatest, which includes a dependency fix for a missing packagesha.jswhich was previously required transitively (revealing the bug that it was missing all along). apollographql/apollo-tooling#2283Fixes #692.
Fixes #693.