Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensibility based on Tower #303

Closed
39 of 41 tasks
BrynCooke opened this issue Jan 6, 2022 · 0 comments
Closed
39 of 41 tasks

Extensibility based on Tower #303

BrynCooke opened this issue Jan 6, 2022 · 0 comments
Assignees

Comments

@BrynCooke
Copy link
Contributor

BrynCooke commented Jan 6, 2022

It has been proposed that we shift our architecture to a Tower based pipeline to:

  1. Support a clean model for extending functionality.
  2. Provide us with off the shelf functionality common to proxy type software.
  3. Reduce our architectural churn.

The router already uses Tower internally, so moving our existing components to services should be something we can do gradually.

A mockup to demonstrate how this could look has been created, but the public facing API need to be developed and we need to prove that Tower is going to work for us.

Execution is split in to phases after which we reevaluate if we need to pivot. After each phase the tasks for the following phase will be converted to tickets.

Phase 1 (1 week) (COMPLETED!):

Phase 2 (1 month) (NEARLY!):

* = broken but was working previously

Phase 3 (After merge)

Note that the following tickets need to be prioritized. They are just a bucket of ideas right now:

@BrynCooke BrynCooke added 2022-02 and removed 2022-02 labels Jan 6, 2022
@BrynCooke BrynCooke changed the title Investigate moving internal architecture to Tower Extensibility based on Tower Jan 6, 2022
@BrynCooke BrynCooke self-assigned this Jan 6, 2022
@abernix abernix removed the 2022-03 label Jan 24, 2022
@abernix abernix closed this as completed Mar 8, 2022
@abernix abernix added this to the v0.1.0-alpha.9 milestone Mar 16, 2022
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this issue Oct 16, 2023
…lographql#303)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@apollo/utils.usagereporting](https://togithub.com/apollographql/apollo-utils)
| [`^2.0.0` ->
`^3.0.0`](https://renovatebot.com/diffs/npm/@apollo%2futils.usagereporting/2.0.0/3.0.0)
|
[![age](https://badges.renovateapi.com/packages/npm/@apollo%2futils.usagereporting/3.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@apollo%2futils.usagereporting/3.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@apollo%2futils.usagereporting/3.0.0/compatibility-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@apollo%2futils.usagereporting/3.0.0/confidence-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>apollographql/apollo-utils</summary>

###
[`v3.0.0`](https://togithub.com/apollographql/apollo-utils/blob/HEAD/packages/usageReporting/CHANGELOG.md#&#8203;300)

[Compare
Source](https://togithub.com/apollographql/apollo-utils/compare/@apollo/utils.usagereporting@2.0.1...@apollo/utils.usagereporting@3.0.0)

##### Major Changes

-
[#&#8203;271](https://togithub.com/apollographql/apollo-utils/pull/271)
[`4e85af0`](https://togithub.com/apollographql/apollo-utils/commit/4e85af042dda5d0c97048ef14861417d1d2488bd)
Thanks [@&#8203;trevor-scheer](https://togithub.com/trevor-scheer)! -
Drop support for Node.js v14

##### Patch Changes

- Updated dependencies
\[[`4e85af0`](https://togithub.com/apollographql/apollo-utils/commit/4e85af042dda5d0c97048ef14861417d1d2488bd)]:
-
[@&#8203;apollo/utils](https://togithub.com/apollo/utils).printwithreducedwhitespace@3.0.0
-
[@&#8203;apollo/utils](https://togithub.com/apollo/utils).stripsensitiveliterals@3.0.0
-
[@&#8203;apollo/utils](https://togithub.com/apollo/utils).dropunuseddefinitions@3.0.0
-
[@&#8203;apollo/utils](https://togithub.com/apollo/utils).removealiases@3.0.0
-
[@&#8203;apollo/utils](https://togithub.com/apollo/utils).sortast@3.0.0

###
[`v2.0.1`](https://togithub.com/apollographql/apollo-utils/blob/HEAD/packages/usageReporting/CHANGELOG.md#&#8203;201)

[Compare
Source](https://togithub.com/apollographql/apollo-utils/compare/@apollo/utils.usagereporting@2.0.0...@apollo/utils.usagereporting@2.0.1)

##### Patch Changes

-
[#&#8203;266](https://togithub.com/apollographql/apollo-utils/pull/266)
[`ba46d81`](https://togithub.com/apollographql/apollo-utils/commit/ba46d817a97a6bad9b0ec6ff0720f01edc806091)
Thanks [@&#8203;renovate](https://togithub.com/apps/renovate)! - Start
building packages with TypeScript v5, which should have no effect for
consumers

- Updated dependencies
\[[`ba46d81`](https://togithub.com/apollographql/apollo-utils/commit/ba46d817a97a6bad9b0ec6ff0720f01edc806091)]:
-
[@&#8203;apollo/utils](https://togithub.com/apollo/utils).printwithreducedwhitespace@2.0.1
-
[@&#8203;apollo/utils](https://togithub.com/apollo/utils).dropunuseddefinitions@2.0.1
-
[@&#8203;apollo/utils](https://togithub.com/apollo/utils).removealiases@2.0.1
-
[@&#8203;apollo/utils](https://togithub.com/apollo/utils).sortast@2.0.1
-
[@&#8203;apollo/utils](https://togithub.com/apollo/utils).stripsensitiveliterals@2.0.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/apollographql/federation-rs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNy4xIiwidXBkYXRlZEluVmVyIjoiMzUuODkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
lennyburdette pushed a commit that referenced this issue Dec 20, 2023
feat: carry unions into (inner) connector supergraph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants