PoC with experimental updated line/col support in apollo-compiler #5263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sachin Shinde <sachin@apollographql.com> Co-authored-by: Nicholas Cioli <nicholas.cioli@apollographql.com>
This commit adds the concept of a general `Connector` which handles keeping track of what options are needed for a connector type. As of now, only HTTP is supported.
We use a list of `{name:, value?:, as?:}` object because we can't use an
object — header names aren't valid GraphQL object keys. But it really is
a map, especially so we can easily merge the `@connect` headers into the
`@source` headers, overriding by name. Also, the `value` field can be a
list of values.
…n, while todo!()ing code that no longer compiles
… dependency graph (apollographql/federation-next#286) This PR adds source-aware data structures for graph paths, path trees, and fetch dependency graphs.
…hql/federation-next#287) Previously `source_query_graph()` was returning `&mut SourceFederatedQueryGraphs`, though we'd prefer to give back `&mut SourceFederatedQueryGraph` instead (i.e. hiding other source-kind query graph data, since it turns out we can't really use `super` to hide them in `SourceFederatedQueryGraphs` without eliciting warnings).
…eration-next#288) This PR: - Adjusts the root node mapping to indicate there's only one per supergraph type. - Tracks non-entity nodes in the intra-source builder, so we can add `SourceExit` edges from them if a root appears later.
…l/federation-next#292) This PR: - Adjusts some type/method naming. - Adds explicit data for `GraphqlPath`/`ConnectPath`, to clarify what they could look like. (Which should help when referencing them in task descriptions.)
|
CI performance tests
|
lennyburdette
force-pushed
the
connectors
branch
from
fa13cd4 to
2858152
Compare
|
Feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just demonstrating the required changes if apollographql/apollo-rs#861 is accepted. This is based on my latest
connectorsbranch so I can test what I need e2e. The only changes relevant todevare inapollo-router/src/error.rs(which, maybe should be using the sameGraphQLErrorstruct asapollo-compiler)?