Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization test for sending string tags to Opentelemetry #5352

Closed
wants to merge 9 commits into from

Conversation

tninesling
Copy link
Contributor

Uses apollo-rs fork with NodeStr based on std::sync::Arc


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

@tninesling, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Jun 5, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • xxlarge-request - Stress test with 100 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • no-graphos - Basic stress test, no GraphOS.
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • large-request - Stress test with a 1 MB request payload
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled

@tninesling tninesling requested review from a team as code owners June 5, 2024 16:32
@tninesling
Copy link
Contributor Author

Interestingly, despite having a different string representation in the compiler and reducing the allocations made when converting to OTel values, this latest commit has nearly identical throughput numbers compared to dev.

@tninesling tninesling closed this Jun 5, 2024
@BrynCooke BrynCooke reopened this Jun 6, 2024
@SimonSapin
Copy link
Contributor

SimonSapin commented Jun 18, 2024

After apollographql/apollo-rs#868 then #5477 are merged this PR can be updated to use something like:

fn compiler_name_to_otel_value(name: &Name) -> Option<opentelemetry::Value> {
    Some(opentelemetry_api::Value::String(compiler_name_to_otel_string(name)))
}

fn compiler_name_to_otel_string(name: &Name) -> opentelemetry::StringValue {
    if let Some(static_str) = name.as_static_str() {
        static_str.into()
    } else {
        // One of as_static_str() or to_cloned_arc() always returns Some
        name.to_cloned_arc().unwarp().into()
    }
}

@tninesling tninesling closed this Jun 26, 2024
@tninesling tninesling deleted the tninesling/otel-str-optimizations branch June 26, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants