-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization test for sending string tags to Opentelemetry #5352
Conversation
@tninesling, please consider creating a changeset entry in |
CI performance tests
|
…ts again because they hung last time
Interestingly, despite having a different string representation in the compiler and reducing the allocations made when converting to OTel values, this latest commit has nearly identical throughput numbers compared to dev. |
…nless there is a value.
After apollographql/apollo-rs#868 then #5477 are merged this PR can be updated to use something like: fn compiler_name_to_otel_value(name: &Name) -> Option<opentelemetry::Value> {
Some(opentelemetry_api::Value::String(compiler_name_to_otel_string(name)))
}
fn compiler_name_to_otel_string(name: &Name) -> opentelemetry::StringValue {
if let Some(static_str) = name.as_static_str() {
static_str.into()
} else {
// One of as_static_str() or to_cloned_arc() always returns Some
name.to_cloned_arc().unwarp().into()
}
} |
Uses apollo-rs fork with NodeStr based on std::sync::Arc
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩