Update to apollo-compiler v1.0.0-beta.18 #5477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimonSapin, please consider creating a changeset entry in |
|
CI performance tests
|
SimonSapin
commented
Jun 18, 2024
| @@ -48,7 +48,7 @@ debug = 1 | |||
| # Dependencies used in more than one place are specified here in order to keep versions in sync: | |||
| # https://doc.rust-lang.org/cargo/reference/workspaces.html#the-dependencies-table | |||
| [workspace.dependencies] | |||
| apollo-compiler = "=1.0.0-beta.17" | |||
| apollo-compiler = "=1.0.0-beta.18" | |||
There was a problem hiding this comment.
This PR is a draft for now because this version does not exist yet
| @@ -80,38 +79,6 @@ pub(crate) fn directive_required_string_argument( | |||
| }) | |||
| } | |||
|
|
|||
| pub(crate) fn directive_optional_fieldset_argument( | |||
There was a problem hiding this comment.
This was the same as directive_optional_string_argument
| } | ||
| } | ||
|
|
||
| pub(crate) fn directive_required_fieldset_argument( |
There was a problem hiding this comment.
This was the same as directive_required_string_argument
This was referenced Jun 18, 2024
% Conflicts: % Cargo.lock % apollo-federation/src/merge.rs % apollo-federation/src/query_graph/graph_path.rs % apollo-router/src/query_planner/bridge_query_planner.rs % apollo-router/src/query_planner/dual_query_planner.rs
SimonSapin
requested review from
a team,
benjamn,
dariuszkuc,
sachindshinde,
goto-bus-stop,
lrlna,
TylerBloom and
duckki
as code owners
SimonSapin
commented
Jun 27, 2024
| @@ -128,7 +128,7 @@ async fn test_validation_error() { | |||
| } | |||
| }, | |||
| { | |||
| "message": "Field \"topProducts\" of type \"Product\" must have a selection of subfields. Did you mean \"topProducts { ... }\"?", | |||
| "message": "Field \"topProducts\" of type \"Query\" must have a selection of subfields. Did you mean \"topProducts { ... }\"?", | |||
There was a problem hiding this comment.
The previous message was wrong. apollographql/apollo-rs#865 fixed it.
goto-bus-stop
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apollographql/apollo-rs#868 introduced some breaking changes that cause a large but not complex diff here.