Fragment warnings #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also normalize document strings (for whitespace anyway). Note that we are simply checking fragment strings for equality, not ensuring that fragment definitions within the larger graphql document have exact equality. We could do the above, but it'd be quite a bit more complicated, and I'm not sure if there's much benefit. AFAICT the main reason for wanting that before was exactly this functionality.
|
@stubailo might want to have a look at this also. |
tmeasday
force-pushed
the
fragment-warnings
branch
from
422ab33 to
44a69c5
Compare
|
@tmeasday I think this looks great! I think it's perfectly fine to be restrictive and require that a fragment with the same name be identical. I'd even go so far as to not strip whitespace. Can't wait to remove fragment stuff from Apollo Client! I hear 0.6 is right around the corner... 😉 |
|
Small test fixes needed: apollographql/apollo-client#976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See notes on commit, in particular