Extend FluentWait, so one can set custom polling strategy #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
force-pushed
the
appium_fluent_wait
branch
from
f2d377b
to
d10ffbb
Compare
TikhomirovSergey
approved these changes
Apr 1, 2017
TikhomirovSergey
added a commit
that referenced
this pull request
Apr 2, 2017
…fluent_wait The addition to the #612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Created extended FluentWait class with possibility to allow custom polling strategy. This might be quite useful while working with mobile interfaces where the initial transition animation creates main delay before an element appears on the screen. Having custom polling strategy set allows one to increase this initial polling delay, so the interface has enough time to finish the transition faster without being unnecessarily interrupted by Appium agent calls.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
I don't really like the implementation myself, since it is necessary to access private fields of the parent class via reflection API. Please let me know if you have better ideas on how to implement it.