Skip to content

The addition to the #612 #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2017
Merged

The addition to the #612 #613

merged 4 commits into from
Apr 2, 2017

Conversation

TikhomirovSergey
Copy link
Contributor

Change list

  • the AppiumFluentWaitTest was improved
  • minor codestyle issue fixes

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Mykola Mokhnach and others added 4 commits March 30, 2017 21:04
@TikhomirovSergey TikhomirovSergey self-assigned this Apr 1, 2017
@TikhomirovSergey TikhomirovSergey added this to the 5.0.0 milestone Apr 1, 2017
@mykola-mokhnach
Copy link
Contributor

Thanks for fixes @TikhomirovSergey
However, I believe I could do the stuff myself if you just comment it in the PR.

@TikhomirovSergey TikhomirovSergey merged commit 83c17c1 into appium:master Apr 2, 2017
@TikhomirovSergey
Copy link
Contributor Author

TikhomirovSergey commented Apr 2, 2017 •
edited
Loading

@mykola-mokhnach ok. I just decided to fix other codestyle issues which were not related to the PR. I usually repark proposed stuff and I will do it next times :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TikhomirovSergey TikhomirovSergey

Labels
bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TikhomirovSergey @mykola-mokhnach