update selenium-webdriver 3.0 and add patches to work with Appium

[KazuCocoa]

This PR is for selenium-webdriver 3.0.0 and 3.0.1.
Over 3.0.2, we need #413 .

motivation

Using selenium-webdriver 3.0 instead of selenium-webdriver 2.x to catch up with the latest maintained library.

What I do

Fix some issues I encountered issues I ran my test suite with selenium-webdriver 3.0.

We should use legacy Bridge to compatible with Appium server. W3CBridge, used in Selenium3 Ruby client by default, differs paths between selenium-webdriver 2.x and selenium-webdriver 3.x. So, we encounter some no route error if we use W3CBridge. For instance, the following paths are changed paths between selenium-webdriver 2.x and selenium-webdriver 3.x.

• selenium-webdriver 2.x with Bridge

        command :setWindowSize, :post, 'session/:session_id/window/:window_handle/size'
        command :executeScript, :post, 'session/:session_id/execute'
        command :executeAsyncScript, :post, 'session/:session_id/execute_async'

• selenium-webdriver 3.0 with W3CBridge

        command :getWindowSize, :get, 'session/:session_id/window/size'
        command :getPageSource, :get, '/session/:session_id/source'
        command :executeScript, :post, 'session/:session_id/execute/sync'
        command :executeAsyncScript, :post, 'session/:session_id/execute/async'

---

Fixed issues

1. selenium-webdriver 3.0 client freeze Selenium::WebDriver::SearchContext::FINDERS. But ruby_lib extends the attribute. So, I've added search context for Appium .
2. Selenium::Client is removed from selenium-webdriver. So, re-define iOS error in ruby_lib.
3. Not supported and not found routes error with W3CBridge
   • Force use Bridge to use Capabilities class for firefox
     • 159f937
   • Example of logs when use W3CBridge as bridge module
     • => https://gist.github.com/KazuCocoa/64546c2f59c79376a05c329ffc89918f

---

Routes

• https://github.com/SeleniumHQ/selenium/blob/ceaf3da79542024becdda5953059dfbb96fb3a90/rb/lib/selenium/webdriver/remote/commands.rb
• https://github.com/SeleniumHQ/selenium/blob/selenium-3.0.0/rb/lib/selenium/webdriver/remote/w3c_commands.rb

---

Appium server's routes are based on mobile-json-wire-protocol. So, the commands differ from w3c one.

[KazuCocoa]

This PR may solve Bump selenium-webdriver dependency #382

[KazuCocoa]

I update commits and this PR works fine in my test suites.
What I do in this PR is described in description.

An important point in this PR is that using Bridge instead of W3CBridge to send previous version's commands to Appium server because Appium Server raise no route error for W3C commands .

@jlipps Could you check the patch policy?
If Appium server will support W3C command completely in the future, then we should remove patch_webdriver_driver, I already commend as TODO.

If using Bridge is OK, I'd like to review this PR's code and merge this.

[sofaking]

Wouldn't it be more pragmatic to just wait until selenium 3 routs will be implemented in Appium server ? This PR obviously introduce some unnecessary complexity while I'm not sure what exactly Selenium 3.0 brings to the table.

[KazuCocoa]

Yes, I agree... > This PR obviously introduce some unnecessary complexity...
So, if Appium has decided to continue to use selenium-webdriver 2.x, I'd like to close this PR.
(I found introducing selenium3.0 in Java client, so I just tried to this PR)

[KazuCocoa]

@jlipps what do you think ? => #383 (comment)

[jsf-clabot]

All committers have signed the CLA.

[jlipps]

We will certainly be supporting the se3-style clients in the Appium server. So I think this patch is relevant. But I'm not sure exactly when this will happen. @KazuCocoa do you have a link that explains the differences between what the se3 clients send and what the Appium server expects?

[KazuCocoa]

• I update description. The following logs are example when appium server raise no route found.
  • https://gist.github.com/KazuCocoa/64546c2f59c79376a05c329ffc89918f
• in selenium-webdriver3 library for ruby, this routes for w3c bridge commands are called by default.
• previous library, selenium-webdriver2, calls this routes.
• Diff between bridge and w3c bridge. Some commands(URI) are changed from bridge to w3c bridge.
  • https://gist.github.com/KazuCocoa/01130525b01ebed218460a271e959a9f

[KazuCocoa]

Some methods in selenim-webdriver 3.0 are renamed.

[KazuCocoa]

Selenium::Client were removed

[KazuCocoa]

@jlipps ^ the above comments is what you wanted ? Could you check again ? 🙇

[KazuCocoa]

Use ::Selenium::WebDriver::Remote::Capabilities.new to define capability to remove patch.

[KazuCocoa]

Update this description

[KazuCocoa]

according to the "Bump selenium-webdriver dependency #382", someone uses appium_lib with selenium-webdriver. So, they need appium_lib's dependencies over selenium-webdriver3.

So, I'd like to merge this after self-review for them.

[jlipps]

👍