[Index/USRGeneration] Make sure that ObjC properties in categories also get namescoped properly for USR generation #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so get namescoped properly for USR generation If the property is in a category that has module names from external_declaration property, make sure they are included in the USR. rdar://59897320
Author
|
@swift-ci test OS X platform |
swift-ci
pushed a commit
to swiftlang/swift
that referenced
this pull request
Mar 10, 2020
… the clang side This is a Swift-side test case for swiftlang/llvm-project#887 Ensures Swift and Clang are in-sync on the USRs for exported properties.
akyrtzi
added a commit
to swiftlang/swift
that referenced
this pull request
Mar 12, 2020
… the clang side This is a Swift-side test case for swiftlang/llvm-project#887 Ensures Swift and Clang are in-sync on the USRs for exported properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the property is in a category that has module names from external_declaration property, make sure they are included in the USR.
rdar://59897320