Skip to content

Make initializers '@usableFromInline' instead of '@inlinable' to support building for library evolution #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2022
Merged

Make initializers '@usableFromInline' instead of '@inlinable' to support building for library evolution #205

merged 1 commit into from
Oct 5, 2022

Conversation

jefflewis
Copy link
Contributor

@jefflewis jefflewis commented Oct 5, 2022 •
edited
Loading

Fixes #204

To test, run

xcodebuild archive -scheme AsyncAlgorithms -destination "generic/platform=iOS" SKIP_INSTALL=NO BUILD_LIBRARY_FOR_DISTRIBUTION=YES

on this branch vs main. I'll note I'm building the archive with Xcode 14.0.1.

@jefflewis
Copy link
Contributor Author

I'll also note that I did this work off of 0.0.1 because 0.0.2 and later break macOS builds. Butt the changes seem to apply generally.

phausler
phausler approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, these may eventually become frozen but for now this is probably the right approach.

@phausler phausler merged commit 4feeb83 into apple:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler phausler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archive failures when included in framework built with BUILD_LIBRARY_FOR_DISTRIBUTION=YES
2 participants
@jefflewis @phausler