Skip to content

Make initializers '@usableFromInline' instead of '@inlinable' to support building for library evolution #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Make initializers '@usableFromInline' instead of '@inlinable' to support building for library evolution #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/AsyncAlgorithms/AsyncChunkedByGroupSequence.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public struct AsyncChunkedByGroupSequence<Base: AsyncSequence, Collected: RangeR
@usableFromInline
let grouping : @Sendable (Base.Element, Base.Element) -> Bool

@inlinable
@usableFromInline
init(_ base: Base, grouping: @escaping @Sendable (Base.Element, Base.Element) -> Bool) {
self.base = base
self.grouping = grouping
Expand Down
3 changes: 1 addition & 2 deletions Sources/AsyncAlgorithms/AsyncChunkedOnProjectionSequence.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public struct AsyncChunkedOnProjectionSequence<Base: AsyncSequence, Subject: Equ
@usableFromInline
let projection : @Sendable (Base.Element) -> Subject

@inlinable
@usableFromInline
init(_ base: Base, projection: @escaping @Sendable (Base.Element) -> Subject) {
self.base = base
self.projection = projection
Expand All @@ -98,4 +98,3 @@ public struct AsyncChunkedOnProjectionSequence<Base: AsyncSequence, Subject: Equ

extension AsyncChunkedOnProjectionSequence : Sendable where Base : Sendable, Base.Element : Sendable { }
extension AsyncChunkedOnProjectionSequence.Iterator : Sendable where Base.AsyncIterator : Sendable, Base.Element : Sendable, Subject : Sendable { }

2 changes: 1 addition & 1 deletion Sources/AsyncAlgorithms/AsyncChunksOfCountSequence.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public struct AsyncChunksOfCountSequence<Base: AsyncSequence, Collected: RangeRe
@usableFromInline
let count : Int

@inlinable
@usableFromInline
init(_ base: Base, count: Int) {
precondition(count > 0)
self.base = base
Expand Down
4 changes: 2 additions & 2 deletions Sources/AsyncAlgorithms/AsyncInterspersedSequence.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public struct AsyncInterspersedSequence<Base: AsyncSequence> {
@usableFromInline
internal let separator: Base.Element

@inlinable
@usableFromInline
internal init(_ base: Base, separator: Base.Element) {
self.base = base
self.separator = separator
Expand Down Expand Up @@ -61,7 +61,7 @@ extension AsyncInterspersedSequence: AsyncSequence {
@usableFromInline
internal var state = State.start

@inlinable
@usableFromInline
internal init(_ iterator: Base.AsyncIterator, separator: Base.Element) {
self.iterator = iterator
self.separator = separator
Expand Down
4 changes: 2 additions & 2 deletions Sources/AsyncAlgorithms/AsyncJoinedBySeparatorSequence.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public struct AsyncJoinedBySeparatorSequence<Base: AsyncSequence, Separator: Asy
@usableFromInline
var state: State

@inlinable
@usableFromInline
init(_ iterator: Base.AsyncIterator, separator: Separator) {
state = .initial(iterator, separator)
}
Expand Down Expand Up @@ -128,7 +128,7 @@ public struct AsyncJoinedBySeparatorSequence<Base: AsyncSequence, Separator: Asy
@usableFromInline
let separator: Separator

@inlinable
@usableFromInline
init(_ base: Base, separator: Separator) {
self.base = base
self.separator = separator
Expand Down
2 changes: 1 addition & 1 deletion Sources/AsyncAlgorithms/AsyncJoinedSequence.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public struct AsyncJoinedSequence<Base: AsyncSequence>: AsyncSequence where Base
@usableFromInline
let base: Base

@inlinable
@usableFromInline
init(_ base: Base) {
self.base = base
}
Expand Down
4 changes: 2 additions & 2 deletions Sources/AsyncAlgorithms/AsyncRemoveDuplicatesSequence.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public struct AsyncRemoveDuplicatesSequence<Base: AsyncSequence>: AsyncSequence
@usableFromInline
var last: Element?

@inlinable
@usableFromInline
init(iterator: Base.AsyncIterator, predicate: @escaping @Sendable (Element, Element) async -> Bool) {
self.iterator = iterator
self.predicate = predicate
Expand Down Expand Up @@ -105,7 +105,7 @@ public struct AsyncThrowingRemoveDuplicatesSequence<Base: AsyncSequence>: AsyncS
@usableFromInline
var last: Element?

@inlinable
@usableFromInline
init(iterator: Base.AsyncIterator, predicate: @escaping @Sendable (Element, Element) async throws -> Bool) {
self.iterator = iterator
self.predicate = predicate
Expand Down