Skip to content

Conversation

carlynorama
Copy link
Contributor

Motivation

I believe the line .package(path: "../.."), in the Package.swift of the Hummingbird example is vestigial from perhaps a previous version where it was just a Package.swift and a main.swift. If it is need explicitly for a container build, please mention in the docs because a regular swift build to test the app locally doesn't work until it is removed.

Modifications

removed the single line .package(path: "../..") from the Package.swift in the Hummingbird example.

Result

Example will now build to be tested pre-containerization test.

Test Plan

Don't believe change needs a test as the example already does not have tests.

@heckj heckj requested a review from euanh August 27, 2025 16:49
@carlynorama
Copy link
Contributor Author

carlynorama commented Aug 30, 2025

Is there anything I can do to help with the failed checks? I have exactly this example with the correction running now in a private repo, talking to a local podman repository, responding to curl just fine. I can make it public if it will help.

@euanh
Copy link
Collaborator

euanh commented Sep 15, 2025

@carlynorama Thank you for noticing this! I'm sorry it's taken me a while to get back to you.

Could you please update your PR to put back the .package(url: "https://github.com/apple/swift-container-plugin", from: "1.0.0"), line which I accidentally removed in de7bef0? That should make the test pass again.

Package.swift should end up looking similar to HelloWorldWithResources:

dependencies: [
.package(url: "https://github.com/hummingbird-project/hummingbird.git", from: "2.1.0"),
.package(url: "https://github.com/apple/swift-container-plugin", from: "1.0.0"),
.package(url: "https://github.com/apple/swift-argument-parser", from: "1.3.0"),

This happened because I had changed the example so that when I built it locally it would use the checked-out version of the plugin and let me test my work in progress changes. This was just a temporary change and I didn't intend to commit it. 🤦

The test is failing now because, without either the fully-qualified .package statement or the relative ../.. one, HelloWorldHummingbird has no dependency on swift-container-plugin, so the plugin is not available. The end-to-end CI job actually rewrites the fully-qualified dependency to ensure that the test is using the latest version of the plugin.

@carlynorama carlynorama requested a review from euanh September 19, 2025 17:37
@carlynorama
Copy link
Contributor Author

carlynorama commented Sep 19, 2025

No worries about the delay! Did I do it right?

@euanh euanh added kind/bug Something isn't working semver/none No version bump required. kind/administration CI, repo automation, other admin tasks area/testing Improvements to tests. labels Sep 22, 2025
Copy link
Collaborator

@euanh euanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you.

@euanh euanh merged commit b05db25 into apple:main Sep 22, 2025
46 of 48 checks passed
@euanh
Copy link
Collaborator

euanh commented Sep 22, 2025

The 6.2 test failure may be for the same reason as #158 - the GitHub runner isn't picking up the configuration change. Should pass when force-merged to main.

@carlynorama carlynorama deleted the example-edit branch September 27, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing Improvements to tests. kind/administration CI, repo automation, other admin tasks kind/bug Something isn't working semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants