-
Notifications
You must be signed in to change notification settings - Fork 18
Update Package.swift #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Package.swift #153
Conversation
Is there anything I can do to help with the failed checks? I have exactly this example with the correction running now in a private repo, talking to a local podman repository, responding to curl just fine. I can make it public if it will help. |
@carlynorama Thank you for noticing this! I'm sorry it's taken me a while to get back to you. Could you please update your PR to put back the
swift-container-plugin/Examples/HelloWorldWithResources/Package.swift Lines 22 to 25 in 9417b63
This happened because I had changed the example so that when I built it locally it would use the checked-out version of the plugin and let me test my work in progress changes. This was just a temporary change and I didn't intend to commit it. 🤦 The test is failing now because, without either the fully-qualified |
No worries about the delay! Did I do it right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you.
The 6.2 test failure may be for the same reason as #158 - the GitHub runner isn't picking up the configuration change. Should pass when force-merged to main. |
Motivation
I believe the line
.package(path: "../.."),
in thePackage.swift
of the Hummingbird example is vestigial from perhaps a previous version where it was just aPackage.swift
and amain.swift
. If it is need explicitly for a container build, please mention in the docs because a regularswift build
to test the app locally doesn't work until it is removed.Modifications
removed the single line
.package(path: "../..")
from thePackage.swift
in the Hummingbird example.Result
Example will now build to be tested pre-containerization test.
Test Plan
Don't believe change needs a test as the example already does not have tests.