ci: Add --skip flags for Swift 6.2 matrix job #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
force-pushed
the
swift-6.2-overrides
branch
from
948c0d7 to
52261b7
Compare
Motivation ---------- Swift NIO's unit test matrix job has been [updated for Swift 6.2](apple/swift-nio#3374), so additional override flags must be defined. Modifications ------------- Define `linux_6.2_arguments_override` for pull requests and the scheduled build on main. Result ------ Tests with Swift 6.2 will pass. Test Plan --------- Existing tests pass again.
euanh
force-pushed
the
swift-6.2-overrides
branch
from
52261b7 to
7f57d1e
Compare
euanh
added
semver/none
|
Overriding the failing 6.2 test: GitHub won't pick up the |
This was referenced Sep 22, 2025
Merged
euanh
added a commit
that referenced
this pull request
Sep 25, 2025
Motivation ---------- #158 added Swift 6.2 flags to the `main` workflow, but the `pull_request` workflow has a separate list of flags which was not updated. Modifications ------------- Update `pull_request` workflow to match `main`. Result ------ Correct 6.2 flags will be applied to pull request workflow runs. Test Plan --------- This PR will fail because the integration and end-to-end tests does still install the 6.1 Static SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Swift NIO's unit test matrix job has been updated for Swift 6.2, so additional override flags must be defined.
Modifications
Define
linux_6_2_arguments_overridefor pull requests and the scheduled build on main.Result
Tests with Swift 6.2 will pass.
Test Plan
Existing tests pass again.