Add upcoming feature flag annotations #2370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an annotation to each upcoming feature flag that is enabled by default in an announced Swift language mode. At present that is only Swift 6 language mode. Note the `ExistentialAny` flag is not enabled by default in Swift 6 language mode and thereforedoes not have an added annotation.
There was a problem hiding this comment.
Other proposals might also need updating, with the following upcoming features:
UPCOMING_FEATURE(StrictConcurrency, 0337, 6)
UPCOMING_FEATURE(ImplicitOpenExistentials, 352, 6)
UPCOMING_FEATURE(GlobalConcurrency, 412, 6)
UPCOMING_FEATURE(RegionBasedIsolation, 414, 6)
proposals/0383-deprecate-uiapplicationmain-and-nsapplicationmain.md
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Since each of these may have a reason why the feature flag is not listed in the proposal, I've opened a PR for each and CC'd the authors/review manager for the proposal to figure out what should be done for each: |
rjmccall
added
LSG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on conversations with the LSG, this PR adds an annotation to each upcoming feature flag that is enabled by default in an announced Swift language mode.
There is no annotation for flags enabled by default in a future, unannounced language mode.
For example, the
ExistentialAnyflag introduced with SE-0335 is not enabled by default in Swift 6 language mode and therefore does not have an added annotation (or appear in this PR).