Fix formatting when respectsExistingLineBreaks is false. #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, we accidentally broke formatting in this mode (when ignoring user-discretionary line breaks) and it turns out we didn't have any testing with that mode applied to catch this. This change fixes it, strengthens the old support to handle semicolon-delimited statements/declarations, and adds some regression tests to make sure we don't break again.
akyrtzi
approved these changes
Oct 7, 2019
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Oct 8, 2019
Fix formatting when respectsExistingLineBreaks is false.
aaditya-chandrasekhar
pushed a commit
to val-verde/swift-format
that referenced
this pull request
May 20, 2021
Add baseURL option to generate command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, we accidentally broke formatting in this mode (when
ignoring user-discretionary line breaks) and it turns out we didn't
have any testing with that mode applied to catch this. This change
fixes it, strengthens the old support to handle semicolon-delimited
statements/declarations, and adds some regression tests to make sure
we don't break again.