TestMetrics.FullKey hash goes via Dictionary #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently a change was made to the `TestMetrics.FullKey.hash` method to make the hashing output stable and remove its dependency on the order of the key-value pairs. This PR retains that property but instead of sorting first inserts the key-value pairs into a `Dictionary` as is done in the `==` method. This is useful because it more clearly indicates that the type will comply with the requirement that anything that is equal must produce the same hash.
FranzBusch
approved these changes
Sep 1, 2025
czechboy0
added
🔨 semver/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestMetrics.FullKeyhashgoes via intermediateDictionary.Motivation:
Recently a change was made to the
TestMetrics.FullKey.hashmethod to make the hashing output stable and remove its dependency on the order of the key-value pairs.Modifications:
This PR retains that property but instead of sorting first inserts the key-value pairs into a
Dictionaryas is done in the==method.Result:
This is useful because it more clearly indicates that the type will comply with the requirement that anything that is equal must produce the same hash.